Merged
Conversation
| file_urls = self.archive.getArchivefileUrls(filters, allPages) | ||
| if joinedWithNewline: | ||
| return "\n".join(file_urls) | ||
| else: |
Contributor
There was a problem hiding this comment.
This is a nitpicky comment, but the 'else' is unnecessary, ie:
if joinedWithNewline:
return "\n".join(file_urls)
return file_urls
Collaborator
Author
There was a problem hiding this comment.
Yeah. I normally omit the else when the else part is substantially bigger than the if part, so that it avoids the nesting for the longer code lines by ruling out those small and edge cases in the very beginning. For a one-liner, it looks more balanced to me inside an indentation block. Just a personal preference.
spencerwplovie
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #56
Added two methods (
getArchivefileUrlandgetArchivefileUrls) to only return the URLs of the archivefiles so users can use them in their favorite download manager.Also added an example of how to do that in aria2c.